TTL DIARY

General ramblings by an Optimizely focussed
Technical Team Lead

You don't have to agree with me.

Sometimes I don't want you to.

Nine times out of ten when I post a comment on a PR, I rarely get a reply other than to inform me that the amends I have suggested have been made. Sure, it makes the whole process go quicker, but sometimes I want an argument.

I very rarely have to comment on a PR to tell the contributor what they have done is completely wrong; to throw it in the bin and start all over again. The majority of the time it's more an opportunity for me to:

  • Ask questions and understand why something has been implemented a certain way

  • Propose alternative solutions to reduce cognitive complexity, or keep things consistent

As a Tech Team Lead, what I would love to see more of in response to my comments is the contributor standing behind their implementation, and basically tell me to shove my suggestions up my arse.

Or at the very least, question me right back.

Ask me why I've proposed you amend your solution.

Tell me why you think your implementation is the best approach.

It can only lead to good things; more open discussions, the sharing of knowledge (hopefully with all involved learning a thing or two).

If nothing else, hopefully it can help build the overall confidence within the team, and iterate the fact that team members can challenge each other on their proposed solutions, no matter where they fall on the Job Title spectrum.

A lead won't always have the right answers. They don't know everything. And you don't have to agree with everything they say.